This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][BZ #16398] Fix infinite loop in ftell when writing wide char data

From: Mike Frysinger <vapier at gentoo dot org>
To: libc-alpha at sourceware dot org
Cc: Siddhesh Poyarekar <siddhesh at redhat dot com>
Date: Tue, 04 Feb 2014 03:48:13 -0500
Subject: Re: [PATCH][BZ #16398] Fix infinite loop in ftell when writing wide char data
Authentication-results: sourceware.org; auth=none
References: <20140131051923 dot GL2149 at spoyarek dot pnq dot redhat dot com> <20140131192607 dot 05D5474430 at topped-with-meat dot com> <20140203095340 dot GE5209 at spoyarek dot pnq dot redhat dot com>

On Monday, February 03, 2014 15:23:40 Siddhesh Poyarekar wrote:
> --- /dev/null
> +++ b/libio/tst-ftell-partial-wide.c
>
> +/* Defined in test-skeleton.c.  */
> +static int create_temp_file (const char *base, char **filename);

ugh.  it makes more sense imo (and is safer) to declare do_test static here, 
then move the TEST_FUNCTION define and test-skeleton.c include here.  that way 
you aren't copying & pasting content from test-skeleton.c here.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Follow-Ups:
- Re: [PATCH][BZ #16398] Fix infinite loop in ftell when writing wide char data
  - From: Siddhesh Poyarekar

References:
- Re: [PATCH][BZ #16398] Fix infinite loop in ftell when writing wide char data
  - From: Siddhesh Poyarekar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]