This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RESEND][BZ #15132][PATCH] avoid stat/fstat in statvfs/fstatvfs
- From: Eric Wong <normalperson at yhbt dot net>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: Siddhesh Poyarekar <siddhesh at redhat dot com>, libc-alpha at sourceware dot org
- Date: Sat, 22 Feb 2014 06:39:09 +0000
- Subject: Re: [RESEND][BZ #15132][PATCH] avoid stat/fstat in statvfs/fstatvfs
- Authentication-results: sourceware.org; auth=none
- References: <20140125220000 dot GA19098 at dcvr dot yhbt dot net> <20140127050402 dot GC2149 at spoyarek dot pnq dot redhat dot com> <20140204181702 dot GA25215 at dcvr dot yhbt dot net> <20140221114609 dot GA7772 at domone dot podge>
OndÅej BÃlka <neleai@seznam.cz> wrote:
> > Sorry for the delay. I've only tested on 3.12+ so far on x86_64.
> > I'll try to get a VM setup on <2.6.36 soon
>
> Did you test also with these kernels?
Unfortunately the machine running 2.6.32.x CentOS 6.x kernel
already had Linux commit 365b18189789bfa1acd9939e6312b8a4b4577b28
(add f_flags to struct statfs(64)) backported to it :<
Probably just be easier for me to test with the following kernel patch
than to get an older kernel running:
--- a/fs/statfs.c
+++ b/fs/statfs.c
@@ -42,7 +42,7 @@ static int flags_by_sb(int s_flags)
static int calculate_f_flags(struct vfsmount *mnt)
{
- return ST_VALID | flags_by_mnt(mnt->mnt_flags) |
+ return flags_by_mnt(mnt->mnt_flags) |
flags_by_sb(mnt->mnt_sb->s_flags);
}