This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Ping Re: Consistently include Makeconfig after defining subdir

From: Brooks Moses <bmoses at google dot com>
To: "Joseph S. Myers" <joseph at codesourcery dot com>
Cc: libc-alpha at sourceware dot org
Date: Wed, 26 Feb 2014 10:47:13 -0800
Subject: Re: Ping Re: Consistently include Makeconfig after defining subdir
Authentication-results: sourceware.org; auth=none
References: <Pine dot LNX dot 4 dot 64 dot 1402182257230 dot 31862 at digraph dot polyomino dot org dot uk> <Pine dot LNX dot 4 dot 64 dot 1402251808080 dot 25387 at digraph dot polyomino dot org dot uk> <20140226141752 dot GA29498 at domone dot podge> <Pine dot LNX dot 4 dot 64 dot 1402261824440 dot 11728 at digraph dot polyomino dot org dot uk>

On 02/26/2014 10:26 AM, Joseph S. Myers wrote:

On Wed, 26 Feb 2014, Ondrej Bilka wrote:

On Tue, Feb 25, 2014 at 06:08:24PM +0000, Joseph S. Myers wrote:

Ping.  This patch
<https://sourceware.org/ml/libc-alpha/2014-02/msg00520.html> is pending
review.

Looks ok, mostly mechanical change.


The real question is the design point - whether we want to establish this
standard location to include Makeconfig even if the subdirectory doesn't
actually need it - not the details of the diffs used to achieve that
design.

FWIW, although I can't claim to understand whether there are any potentialsubtle ramifications of that design point, the idea of having this beconsistent seems very sound to me. IMO, if there are any subtle things thatbreak because of it, they should probably be considered things to fix ratherthan reasons not to do this change.


- Brooks

References:
- Consistently include Makeconfig after defining subdir
  - From: Joseph S. Myers
- Ping Re: Consistently include Makeconfig after defining subdir
  - From: Joseph S. Myers
- Re: Ping Re: Consistently include Makeconfig after defining subdir
  - From: OndÅej BÃlka
- Re: Ping Re: Consistently include Makeconfig after defining subdir
  - From: Joseph S. Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]