This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Consistently include Makeconfig after defining subdir

From: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
To: libc-alpha at sourceware dot org
Date: Fri, 28 Feb 2014 09:43:32 +0100
Subject: Re: Consistently include Makeconfig after defining subdir
Authentication-results: sourceware.org; auth=none
References: <Pine dot LNX dot 4 dot 64 dot 1402182257230 dot 31862 at digraph dot polyomino dot org dot uk> <lenco8$5dg$1 at ger dot gmane dot org> <Pine dot LNX dot 4 dot 64 dot 1402271754030 dot 27019 at digraph dot polyomino dot org dot uk>

On 02/27/2014 06:56 PM, Joseph S. Myers wrote:

On Thu, 27 Feb 2014, Stefan Liebler wrote:

2014-02-27  Stefan Liebler  <stli@linux.vnet.ibm.com>

	* csu/Makefile: Use += instead of a =.


OK (with the ChangeLog entry fixed to name the variable involved).

I think the same should apply to other directories setting before-compile
with = or :=, unless they have a good reason for doing so.  (That's elf/
iconvdata/ intl/ posix/.  None were actually affected by my patch because
they had the settings of before-compile below both the old and new
includes of Makeconfig.)


I changed the other Makefiles, too.
Afterwards i successfully tested on S390/S390x.

Bye

---
2014-02-28  Stefan Liebler  <stli@linux.vnet.ibm.com>

	* csu/Makefile: Use += before-compile instead of a = or :=.
	* elf/Makefile: Likewise.
	* iconvdata/Makefile: Likewise.
	* intl/Makefile: Likewise.
	* posix/Makefile: Likewise.
---

Attachment: patchmakefilesbeforecommit
Description: Text document

Follow-Ups:
- Re: Consistently include Makeconfig after defining subdir
  - From: Joseph S. Myers

References:
- Consistently include Makeconfig after defining subdir
  - From: Joseph S. Myers
- Re: Consistently include Makeconfig after defining subdir
  - From: Stefan Liebler
- Re: Consistently include Makeconfig after defining subdir
  - From: Joseph S. Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]