This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix -Wundef warnins for __FP_FAST_FMA*

From: Mike Frysinger <vapier at gentoo dot org>
To: libc-alpha at sourceware dot org
Cc: Roland McGrath <roland at hack dot frob dot com>, Carlos O'Donell <carlos at redhat dot com>, Siddhesh Poyarekar <siddhesh at redhat dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
Date: Wed, 19 Mar 2014 01:42:10 -0400
Subject: Re: [PATCH] Fix -Wundef warnins for __FP_FAST_FMA*
Authentication-results: sourceware.org; auth=none
References: <20140318020544 dot GO1850 at spoyarek dot pnq dot redhat dot com> <5328510F dot 3050003 at redhat dot com> <20140318223618 dot A6F397447D at topped-with-meat dot com>

On Tue 18 Mar 2014 15:36:18 Roland McGrath wrote:
> The context of predefines usually means that the base thing we're looking
> at provided by the compiler has to be tested with #ifdef.  (For any future
> predefines, we should work with compiler folks to suggest that new things
> follow the #if-friendly pattern of macros always defined to either 0 or 1
> rather than the typo-prone pattern of sometimes-defined macros.)

i like the sentiment, but i'm not sure about the practicality.  how do you go 
about deciding whether a macro should always be defined ?  the set of all 
possible defines gcc might create depending on configuration/target settings ?  
seems like you'd easily generate a crap ton of noisy defines and blow past the 
point of usefulness ...
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

References:
- [PATCH] Fix -Wundef warnins for __FP_FAST_FMA*
  - From: Siddhesh Poyarekar
- Re: [PATCH] Fix -Wundef warnins for __FP_FAST_FMA*
  - From: Carlos O'Donell
- Re: [PATCH] Fix -Wundef warnins for __FP_FAST_FMA*
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]