Re: [PATCH 2/2] Initialize all of datahead structure in nscd [BZ #16791]

[Mike Frysinger <vapier at gentoo dot org>]

On Wed 02 Apr 2014 15:10:12 Siddhesh Poyarekar wrote:
> @@ -253,18 +257,21 @@ static inline time_t
>  datahead_init_pos (struct datahead *head, nscd_ssize_t allocsize,
>  		   nscd_ssize_t recsize, uint8_t nreloads, uint32_t ttl)
>  {
> +  time_t ret = datahead_init_common (head, allocsize, recsize, ttl);
>    head->notfound = false;

doesn't GNU style say there should be a new line between decls and code ?  or 
do we not care about that rule in glibc ?

>    head->nreloads = nreloads;
> -  return datahead_init_common (head, allocsize, recsize, ttl);
> +  return ret;

same for return value.

>  static inline time_t
>  datahead_init_neg (struct datahead *head, nscd_ssize_t allocsize,
>  		   nscd_ssize_t recsize, uint32_t ttl)
>  {
> +  time_t ret = datahead_init_common (head, allocsize, recsize, ttl);
> +  /* We don't need to touch nreloads here since it is set to our desired
> value
> +     (0) when we bzero the structure.  */

bzero->clear
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.