This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 1/2] fcntl-linux.h: add new definitions for file-private lock cmd values
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: Jeff Layton <jlayton at redhat dot com>, <libc-alpha at sourceware dot org>
- Date: Wed, 23 Apr 2014 14:47:18 +0000
- Subject: Re: [PATCH v2 1/2] fcntl-linux.h: add new definitions for file-private lock cmd values
- Authentication-results: sourceware.org; auth=none
- References: <1397220945-11926-1-git-send-email-jlayton at redhat dot com> <1397220945-11926-2-git-send-email-jlayton at redhat dot com> <53487CE5 dot 9050903 at redhat dot com> <20140411203703 dot 75dac781 at tlielax dot poochiereds dot net> <53496CB7 dot 2080204 at redhat dot com>
On Sat, 12 Apr 2014, Carlos O'Donell wrote:
> So please use `#if __USE_GNU'.
No. Please keep what's done with any given macro consistent rather than
confusing things by mixing styles for a single macro. That means
__USE_GNU is tested with #ifdef / #ifndef unless and until all definitions
and users are changed to use 0/1 values instead of undefined/defined.
--
Joseph S. Myers
joseph@codesourcery.com