This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] Fix __mips16 undef macro warnings.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: Steve Ellcey <sellcey at mips dot com>, <libc-alpha at sourceware dot org>, <yufeng dot zhang at arm dot com>
- Date: Tue, 29 Apr 2014 21:03:17 +0000
- Subject: Re: [Patch] Fix __mips16 undef macro warnings.
- Authentication-results: sourceware.org; auth=none
- References: <e6d220e3-a7a2-44ba-841f-d0345c15b290 at BAMAIL02 dot ba dot imgtec dot org> <535FF3AE dot 1070301 at redhat dot com> <535FF4E4 dot 3030803 at redhat dot com>
On Tue, 29 Apr 2014, Carlos O'Donell wrote:
> Add a large descriptive comment about the use of __mips16
> here and perhaps even talk about __mips32 and __mips64.
I think a large comment about a compiler-defined macro would be completely
out-of-place in this header - in MIPS-specific code, commenting on a test
of __mips16 is just like
i++; /* Add 1 to i. */
in generic C code. You can comment about *why* testing MIPS16 is
relevant, but *what* the test does and *how* it does it are complete plain
and don't need commenting.
--
Joseph S. Myers
joseph@codesourcery.com