This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] fix nl_langinfo with static linking
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Aurelien Jarno <aurelien at aurel32 dot net>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 6 May 2014 14:04:15 -0700 (PDT)
- Subject: Re: [PATCH] fix nl_langinfo with static linking
- Authentication-results: sourceware.org; auth=none
- References: <1399385072-5600-1-git-send-email-aurelien at aurel32 dot net>
> + ($(objpfx)tst-langinfo.out): Redirect output.
Mention use of $(evaluate-test) too.
> + default: /* Should be impossible. */
> + return (char *) "";
Make this an assert or abort rather than having the library function return
the user error indication for a case that is an implementation bug.
Otherwise looks fine to me (with BZ# added).
Thanks,
Roland