Re: [PATCH] Fix build warning in pthread_rwlock_*

[Siddhesh Poyarekar <siddhesh at redhat dot com>]

On Tue, Jun 24, 2014 at 11:54:14AM +0200, Andreas Schwab wrote:
> Siddhesh Poyarekar <siddhesh@redhat.com> writes:
> 
> > The first argument of elision_adapt and that of ELISION_*LOCK have
> > different signs since __elision_rwcount is singned char and the
> 
> __elision_rwcount doesn't exist.

I have no idea where I got that from; it should have been __rwelision.

> > argument of elision_adapt is uint8_t.  Modified elision_adapt to
> > accept int8_t instead of uint8_t.
> 
> Make it signed char.

Thanks, committed.

Siddhesh

commit 08e5862f5f087138047c757376edb1b63217d547
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date:   Tue Jun 24 16:12:43 2014 +0530

    Fix build warning in pthread_rwlock_*
    
    The first argument of elision_adapt and that of ELISION_*LOCK have
    different signs since __elision_rwcount is signed char * and the
    argument of elision_adapt is uint8_t *.  Modified elision_adapt to
    accept signed char * instead of uint8_t *.

diff --git a/ChangeLog b/ChangeLog
index 9b119b5..8bfdf80 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2014-06-24  Siddhesh Poyarekar  <siddhesh@redhat.com>
 
+	* sysdeps/x86/nptl/elide.h (elision_adapt): Make first
+	argument type signed char.
+
 	* Makerules (check-abi): Dump diff of symlist if the test
 	fails.
 
diff --git a/sysdeps/x86/nptl/elide.h b/sysdeps/x86/nptl/elide.h
index 19f27e5..5befa53 100644
--- a/sysdeps/x86/nptl/elide.h
+++ b/sysdeps/x86/nptl/elide.h
@@ -26,7 +26,7 @@
 /* Adapt elision with ADAPT_COUNT and STATUS and decide retries.  */
 
 static inline bool
-elision_adapt(uint8_t *adapt_count, unsigned int status)
+elision_adapt(signed char *adapt_count, unsigned int status)
 {
   if (status & _XABORT_RETRY)
     return false;

Attachment: pgpMfmrhGdFCW.pgp
Description: PGP signature