This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Handle possible vararg promotion of mode_t in open and friends


On Sun 03 Aug 2014 14:25:12 Rasmus Villemoes wrote:
> Mike Frysinger <vapier@gentoo.org> writes:
> > On Tue 20 May 2014 00:21:50 Rasmus Villemoes wrote:
> >> +      mode = va_arg (ap, __typeof__(+(mode_t)0));
> > 
> > seems like this should be a define in a private header rather than copy &
> > pasted in every call site
> 
> Good idea. I'm not too familiar with glibc's internal organization; in
> particular, I don't know which headers are private and which are
> not. Could you suggest a specific header file to put this in?

i think include/fcntl.h would be best
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]