Re: [PATCH] Revert to defining __extern_inline only for g++-4.3+

[Siddhesh Poyarekar <siddhesh at redhat dot com>]

On Wed, Aug 13, 2014 at 08:51:22PM +0000, Joseph S. Myers wrote:
> On Wed, 13 Aug 2014, Siddhesh Poyarekar wrote:
> 
> > Hi,
> > 
> > The check for only __GNUC_STDC_INLINE__ and __GNUC_GNU_INLINE__ may
> > not be sufficient since those flags were added during initial support
> > for C99 inlining semantics.  There is also a problem with always
> > defining __extern_inline and __extern_always_inline, since it enables
> > inline wrapper functions even when GNU inlining semantics are not
> > guaranteed.  This, along with the possibility of such wrappers using
> > redirection (btowc for example) could result in compiler generating an
> > infinitely recusrive call to the function.
> 
> Are you describing a problem that was user-visible in a glibc release?  (I 
> guess so, since you don't mention any post-2012 commits as having caused a 
> regression.)  What specifically is the problem (building what, with what 
> compiler versions)?  A bug report in glibc Bugzilla is needed if it was 
> user-visible in a release.

Sorry, I have filed a bz now (#17266) with Jakub's explanation; I
should have been clearer in saying that the Red Hat bz I mentioned in
my email is the symptom that we see again now due to the changes to
__extern_always_inline definition in cdefs.h.

Siddhesh

Attachment: pgpgc3NunTwRU.pgp
Description: PGP signature