Re: [PATCH 1/4] Remove Wundef warnings for specification macros

[Siddhesh Poyarekar <siddhesh at redhat dot com>]

On Tue, Sep 23, 2014 at 02:57:18PM +0200, Florian Weimer wrote:
> On 09/19/2014 12:20 PM, Siddhesh Poyarekar wrote:
> >+$(objpfx)confdefs-defs.h: conf.list Makefile
> >+	$(make-target-directory)
> >+	$(AWK) -f $(..)scripts/gen-conf.awk $< > $@.tmp
> >+	mv -f $@.tmp $@
> 
> Missing dependency on $(..)scripts/gen-conf.awk, I think.

Right, thanks.

> 
> >diff --git a/posix/conf.list b/posix/conf.list
> >new file mode 100644
> >index 0000000..d048568
> >--- /dev/null
> >+++ b/posix/conf.list
> >@@ -0,0 +1,23 @@
> >+# Configuration variables identified by getconf.  The heading of each section
> >+# is of the format TYPE:PREFIX:SC_PREFIX with the opening curly brace on the
> >+# same line.  TYPE can either be SYSCONF, PATHCONF, CONFSTR or SPEC.  In the
> >+# absence of SC_PREFIX, _SC is used as the SC_PREFIX.  Variable names are put
> >+# one on each line with a curly brace on its own line ending the section.
> 
> âSPEC:POSIXâ does not match the âTYPE:PREFIX:SC_PREFIXâ pattern. Looking at
> the awk script, â:SC_PREFIXâ appears superfluous.

Ugh, I wrote that description after Patch 4/4, which is why it shows
the final version of what the script does.  I'll fix it up.

> 
>    #ifdef __ILP32_OFF32_CFLAGS
>    # if CONF_IS_DEFINED_UNSET (_POSIX_V7_ILP32_OFF32)
>    #  error "__ILP32_OFF32_CFLAGS should not be defined"
> 
> I wonder what the purpose of these #errors are.  Is this intended to help
> with porting?

That was my impression.

Siddhesh

Attachment: pgppqI_42VKX4.pgp
Description: PGP signature