This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/8] nptl: Fix testcases for new pthread cancellation, mechanism
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Wed, 8 Oct 2014 23:12:50 +0000
- Subject: Re: [PATCH 3/8] nptl: Fix testcases for new pthread cancellation, mechanism
- Authentication-results: sourceware.org; auth=none
- References: <5435AD7A dot 60400 at linux dot vnet dot ibm dot com>
On Wed, 8 Oct 2014, Adhemerval Zanella wrote:
> For testcases that are not tested in blocked case (pread64 for instance)
> tst-cancel4/5 tests for its cancellation point as 'early exit'. Although
> this is not ideal, 'tst-cancel-wrappers.sh' also does not offer more
> coverage. Ideally and as pointed out in testcases itself, the best option
> would be to create a way to actually block some cancellable entrypoint.
> However, for some syscalls calls this is very trick (pread64 for instance
> does not work on pipe-type descriptors).
I still don't understand exactly what the effects are on test coverage.
Could you provide a list of all the functions tested in
tst-cancel-wrappers.sh, with, for each function, a statement either of the
other testcase that tests cancellation of that function, or of why it is
not possible to test cancellation of that function in a useful way?
--
Joseph S. Myers
joseph@codesourcery.com