This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH roland/nscd-vlais] Rework some nscd code not to use variable-length struct types.
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>, konstantin dot s dot serebryany at gmail dot com
- Date: Thu, 23 Oct 2014 00:01:35 +0200
- Subject: Re: [PATCH roland/nscd-vlais] Rework some nscd code not to use variable-length struct types.
- Authentication-results: sourceware.org; auth=none
- References: <20141022212008 dot 67EC42C3ABF at topped-with-meat dot com>
Roland McGrath <roland@hack.frob.com> writes:
> * inet/netgroup.h (struct name_list): Use C99 [] syntax rather than
> old GNU extension [0] syntax.
> * nscd/nscd_helper.c (open_socket): Use a flexible array member and
> alloca rather than an array member with variable length.
> * nscd/netgroupcache.c (addgetnetgrentX): Likewise.
> * nscd/nscd.c (invalidate_db): New function, broken out of ...
> (parse_opt): ... here. Likewise use alloca there.
> Validate the -i argument before checking for rootness.
> (send_shutdown): New function, broken out of ...
> (parse_opt): ... here.
Looks good.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."