This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: sparc: fix for missing include file
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: davem at davemloft dot net
- Cc: Waldemar Brodkorb <wbx at openadk dot org>, libc-alpha at sourceware dot org
- Date: Thu, 11 Dec 2014 14:57:16 +0100
- Subject: Re: sparc: fix for missing include file
- Authentication-results: sourceware.org; auth=none
- References: <20140913113918 dot GA22732 at waldemar-brodkorb dot de>
This was not commited yet, David could you commit it?
On Sat, Sep 13, 2014 at 01:39:19PM +0200, Waldemar Brodkorb wrote:
> Fix idea from Roland McGrath <roland@hack.frob.com>
> Fixes following compile error targeting sparc32 v8
>
> ../sysdeps/sparc/sparc32/sem_trywait.c: In function '__new_sem_trywait':
> ../sysdeps/sparc/sparc32/sem_trywait.c:35:11: error: dereferencing
> pointer to incomplete type
> if (isem->value > 0)
> ^
> In file included from ../include/list.h:45:0,
> from ../sysdeps/sparc/nptl/tls.h:28,
> from ../include/errno.h:27,
> from ../sysdeps/sparc/sparc32/sem_trywait.c:20:
> ../sysdeps/sparc/sparc32/sem_trywait.c:38:43: error: dereferencing
> pointer to incomplete type
> val = atomic_decrement_if_positive (&isem->value);
> ^
> ../include/atomic.h:372:18: note: in definition of macro
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
>
> ---
> sysdeps/sparc/sparc32/sem_trywait.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sysdeps/sparc/sparc32/sem_trywait.c b/sysdeps/sparc/sparc32/sem_trywait.c
> index 7d0fc55..ad9b4ad 100644
> --- a/sysdeps/sparc/sparc32/sem_trywait.c
> +++ b/sysdeps/sparc/sparc32/sem_trywait.c
> @@ -22,6 +22,7 @@
> #include <lowlevellock.h>
> #include <internaltypes.h>
> #include <semaphore.h>
> +#include <sparc-nptl.h>
>
> #include <shlib-compat.h>
>