This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] add some -Werror pragmas for tilegx

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Chris Metcalf <cmetcalf at ezchip dot com>, GLIBC Devel <libc-alpha at sourceware dot org>
Date: Fri, 26 Dec 2014 16:49:08 -0800
Subject: Re: [PATCH] add some -Werror pragmas for tilegx
Authentication-results: sourceware.org; auth=none
References: <549DF701 dot 606 at ezchip dot com>

Chris Metcalf wrote:

+          /* Using the tilegx gcc 4.8.2 yields uninitialized warnings
+             here (on the "else if" line) and below.  Compiling the same
+             source code with the same gcc version on x86_64 does not
+             yield the warning, so it is something subtle.  */
+          DIAG_PUSH_NEEDS_COMMENT;
+          DIAG_IGNORE_NEEDS_COMMENT(4.8, "-Wmaybe-uninitialized");
         }
        else if (br_elem->type == COLL_SYM)
         {
+          DIAG_POP_NEEDS_COMMENT;

Can you fix this in a way that doesn't feel like ifdefs that are improperlynested with respect to the actual code? E.g., by moving the "br_elem->type ==COLL_SYM" expression into a static function, and playing with the pragmas onlyinside that function's body?

Follow-Ups:
- Re: [PATCH] add some -Werror pragmas for tilegx
  - From: Chris Metcalf

References:
- [PATCH] add some -Werror pragmas for tilegx
  - From: Chris Metcalf

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]