This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Corrupted test cases since "Don't require test wrappers to preserve environment variables, use more consistent environment" heaps
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Mel Gorman <mgorman at suse dot de>
- Cc: <libc-alpha at sourceware dot org>, Siddhesh Poyarekar <siddhesh at redhat dot com>, Julian Taylor <jtaylor dot debian at googlemail dot com>, Carlos O'Donell <carlos at redhat dot com>
- Date: Tue, 24 Feb 2015 14:35:58 +0000
- Subject: Re: Corrupted test cases since "Don't require test wrappers to preserve environment variables, use more consistent environment" heaps
- Authentication-results: sourceware.org; auth=none
- References: <20150220132747 dot GV3087 at suse dot de> <20150224070118 dot GE23807 at spoyarek dot pnq dot redhat dot com> <20150224104712 dot GZ3087 at suse dot de> <20150224140405 dot GI23372 at suse dot de>
On Tue, 24 Feb 2015, Mel Gorman wrote:
> The test case does not crash but it's clearly corrupted.
>
> Before that commit we have
>
> mel@stampy:~/git-public/glibc > rm -rf obj-verify; git checkout 8540f6d2a74fe9d67440535ebbcfa252180a3172^ | head; mkdir obj-verify; cd obj-verify; ../configure --prefix=/tmp/blah > /dev/null 2>&1 && make -j8 > /dev/null 2>&1 && make -j8 tests > /dev/null 2>&1 ; ./testrun.sh > ./intl/tst-gettext4; cd ..
> HEAD is now at ed36bfa18faf... PowerPC: Fix optimized strncat strlen call
> beauty
> thread 1 call 1 returned: beauty
> beauty
> thread 2 call 1 returned: beauty
> beauty
> thread 1 call 2 returned: beauty
> beauty
> thread 2 call 2 returned: beauty
This is the output when the test fails; "thread 1 call 1 returned" etc.
are failure messages. Before my commit, testrun.sh was not by itself a
correct way of running this test, because it lacked the environment setup
required by this test; that environment setup was local to the
tst-gettext4.sh script.
> And on the commit we get
> mel@stampy:~/git-public/glibc > rm -rf obj-verify; git checkout 8540f6d2a74fe9d67440535ebbcfa252180a3172 | head; mkdir obj-verify; cd obj-verify; ../configure --prefix=/tmp/blah > /dev/null 2>&1 && make -j8 > /dev/null 2>&1 && make -j8 tests > /dev/null 2>&1 ; ./testrun.sh > ./intl/tst-gettext4; cd ..
> Previous HEAD position was ed36bfa18faf... PowerPC: Fix optimized strncat strlen call
> HEAD is now at 8540f6d2a74f... Don't require test wrappers to preserve environment variables, use more consistent environment.
> Schï¿œnheit
> beautￜ
> Schï¿œnheit
> beautￜ
This is passing output (modulo a few character set conversions after the
test produced its output in ISO-8859-1, but the test clearly worked
because it didn't produce any of the "returned" messages from failed
comparisons). Because the environment setup is now shared for all tests
in the makefiles, after my commit testrun.sh is suitable to use to run
this test, and so it runs with the correct passing output.
--
Joseph S. Myers
joseph@codesourcery.com