This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] fix to malloc checking

From: Mike Frysinger <vapier at gentoo dot org>
To: James Lemke <jwlemke at codesourcery dot com>
Cc: libc-alpha <libc-alpha at sourceware dot org>, Andreas Schwab <schwab at suse dot de>, Will Newton <will dot newton at linaro dot org>
Date: Sun, 1 Mar 2015 22:08:59 -0500
Subject: Re: [PATCH] fix to malloc checking
Authentication-results: sourceware.org; auth=none
References: <5462592E dot 9050301 at codesourcery dot com> <5474FA02 dot 6020701 at mentor dot com> <CANu=DmhJ3FqfxCKqoVyuS77UiJ92V8+a3ZuKo3xPX1pxppbxkw at mail dot gmail dot com> <54762A68 dot 5050801 at codesourcery dot com> <mvma92uqwhg dot fsf at hawking dot suse dot de> <54D26B54 dot 9050707 at codesourcery dot com>

On 04 Feb 2015 13:56, James Lemke wrote:
> --- a/malloc/hooks.c
> +++ b/malloc/hooks.c
>  
> +static unsigned char
> +magicbyte (void *p)

could be const

> +{
> +  unsigned char magic;
> +
> +  magic = (((size_t) p >> 3) ^ ((size_t) p >> 11)) & 0xFF;

shouldn't you use uintptr_t instead of size_t ?
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] fix to malloc checking
  - From: James Lemke

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]