This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/6] vfprintf: Define WORK_BUFFER_SIZE

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
Date: Mon, 02 Mar 2015 18:07:11 -0800
Subject: Re: [PATCH 3/6] vfprintf: Define WORK_BUFFER_SIZE
Authentication-results: sourceware.org; auth=none
References: <cover dot 1425246936 dot git dot fweimer at redhat dot com> <eca7d9307beb107523be4450b90908162943994e dot 1425246936 dot git dot fweimer at redhat dot com>

Florian Weimer wrote:

-  CHAR_T work_buffer[1000];
+#define WORK_BUFFER_SIZE 1000
+  CHAR_T work_buffer[WORK_BUFFER_SIZE];

Another nit: I suggest avoiding the macro, as it's confusing when #definedinside a function body but intended to be used outside the function, and insteaddoing this at the top level:


enum { WORK_BUFFER_SIZE = 1000 };

The general idea is to use a macro only when necessary.

Follow-Ups:
- Re: [PATCH 3/6] vfprintf: Define WORK_BUFFER_SIZE
  - From: Florian Weimer

References:
- [PATCH 0/6] Some vfprintf refactoring
  - From: Florian Weimer
- [PATCH 3/6] vfprintf: Define WORK_BUFFER_SIZE
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]