This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #18080] S390: Fix setcontext/swapcontext which are not restoring sigmask.
- From: Florian Weimer <fweimer at redhat dot com>
- To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Date: Wed, 04 Mar 2015 12:49:25 +0100
- Subject: Re: [PATCH][BZ #18080] S390: Fix setcontext/swapcontext which are not restoring sigmask.
- Authentication-results: sourceware.org; auth=none
- References: <md6q4p$556$1 at ger dot gmane dot org>
On 03/04/2015 12:26 PM, Stefan Liebler wrote:
> +volatile int handlerCalled;
I think this should use sigatomic_t.
There are a few missing spaces in function calls:
> +check(const char *funcName)
> + sigprocmask(SIG_BLOCK, NULL, &set);
> + if (sigismember(&set, SIGUSR2) != 0)
> + if (sigismember(&set, SIGUSR1) == 0)
> + if (sigismember(&set, SIGUSR2) == 0)
> + if (sigismember(&oldctx.uc_sigmask, SIGUSR2) == 0)
> + if (sigismember(&oldctx.uc_sigmask, SIGUSR1) == 0)
Sorry, no other comments at this time.
--
Florian Weimer / Red Hat Product Security