This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] improve cexp performance for imaginary inputs

From: Mike Frysinger <vapier at gentoo dot org>
To: Julian Taylor <jtaylor dot debian at googlemail dot com>
Cc: libc-alpha at sourceware dot org
Date: Wed, 4 Mar 2015 22:12:01 -0500
Subject: Re: [PATCH v2] improve cexp performance for imaginary inputs
Authentication-results: sourceware.org; auth=none
References: <1425500809-5569-1-git-send-email-jtaylor dot debian at googlemail dot com>

On 04 Mar 2015 21:26, Julian Taylor wrote:
>  math/s_cexp.c  | 6 +++++-
>  math/s_cexpf.c | 6 +++++-
>  math/s_cexpl.c | 6 +++++-

you should write some ChangeLog entries

> +	      if (__real__ x != 0.)
> +	        {
> +	          exp_val= __ieee754_exp (__real__ x);
> +	        }

you can drop the braces

also need a space before the =

applies to all three changes here
-mike

Attachment: signature.asc
Description: Digital signature

References:
- [PATCH v2] improve cexp performance for imaginary inputs
  - From: Julian Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]