This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch][committed] Fix second instance of BZ #18043

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: Paul Eggert <eggert at cs dot ucla dot edu>
Cc: GLIBC Devel <libc-alpha at sourceware dot org>
Date: Mon, 9 Mar 2015 11:58:36 -0700
Subject: Re: [patch][committed] Fix second instance of BZ #18043
Authentication-results: sourceware.org; auth=none
References: <CALoOobM_bLg9CtR5vF+nfnhVtoZhKKo8extbCwAwmkNAPOSVLg at mail dot gmail dot com> <54FDE447 dot 4040000 at cs dot ucla dot edu>

On Mon, Mar 9, 2015 at 11:19 AM, Paul Eggert <eggert@cs.ucla.edu> wrote:
> On 03/09/2015 07:28 AM, Paul Pluzhnikov wrote:
>>
>> -         if (strchr ("-=?+", words[1 + *offset]) == NULL)
>> +         if (words[1 + *offset] == '\0'
>> +             || strchr ("-=?+", words[1 + *offset]) == NULL)
>
>
> For stuff like this, how about using memchr instead?  E.g.,:

Sounds good to me. Something like attached?


2015-03-09  Paul Pluzhnikov  <ppluzhnikov@google.com>

        [BZ #18043]
        * posix/wordexp.c (CHAR_IN_SET): New macro.
        (parse_param): Use it.



-- 
Paul Pluzhnikov

Attachment: bz18043.patch4.txt
Description: Text document

Follow-Ups:
- Re: [patch][committed] Fix second instance of BZ #18043
  - From: Paul Eggert

References:
- [patch][committed] Fix second instance of BZ #18043
  - From: Paul Pluzhnikov
- Re: [patch][committed] Fix second instance of BZ #18043
  - From: Paul Eggert

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]