This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 02/25] pthread_setaffinity (Linux variant): Rewrite to use VLA instead of alloca

From: Mike Frysinger <vapier at gentoo dot org>
To: Florian Weimer <fweimer at redhat dot com>
Cc: libc-alpha at sourceware dot org
Date: Mon, 16 Mar 2015 12:51:32 -0400
Subject: Re: [PATCH 02/25] pthread_setaffinity (Linux variant): Rewrite to use VLA instead of alloca
Authentication-results: sourceware.org; auth=none
References: <cover dot 1425285061 dot git dot fweimer at redhat dot com> <080236bd5f23d9be4c47794ad23e96d52d380f5d dot 1425285061 dot git dot fweimer at redhat dot com> <20150302195844 dot GA24238 at vapier> <5506E8E6 dot 1000906 at redhat dot com>

On 16 Mar 2015 15:29, Florian Weimer wrote:
> +  for (psize = 128; ; psize *= 2)
> +    {
> +      char buf[psize];
> +      INTERNAL_SYSCALL_DECL (err);

style says there should be a blank line here -- after the decls and before the 
first line of code (the res assignment).  otherwise, this does look better than 
v1.  thanks!
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH 02/25] pthread_setaffinity (Linux variant): Rewrite to use VLA instead of alloca
  - From: Florian Weimer

References:
- [PATCH 00/25] Remove extend_alloca [BZ #18023]
  - From: Florian Weimer
- [PATCH 02/25] pthread_setaffinity (Linux variant): Rewrite to use VLA instead of alloca
  - From: Florian Weimer
- Re: [PATCH 02/25] pthread_setaffinity (Linux variant): Rewrite to use VLA instead of alloca
  - From: Mike Frysinger
- Re: [PATCH 02/25] pthread_setaffinity (Linux variant): Rewrite to use VLA instead of alloca
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]