This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] fix to malloc checking

From: Mike Frysinger <vapier at gentoo dot org>
To: James Lemke <jwlemke at codesourcery dot com>
Cc: libc-alpha <libc-alpha at sourceware dot org>, Andreas Schwab <schwab at suse dot de>, Will Newton <will dot newton at linaro dot org>
Date: Sat, 4 Apr 2015 23:05:55 -0400
Subject: Re: [PATCH] fix to malloc checking
Authentication-results: sourceware.org; auth=none
References: <5462592E dot 9050301 at codesourcery dot com> <5474FA02 dot 6020701 at mentor dot com> <CANu=DmhJ3FqfxCKqoVyuS77UiJ92V8+a3ZuKo3xPX1pxppbxkw at mail dot gmail dot com> <54762A68 dot 5050801 at codesourcery dot com> <mvma92uqwhg dot fsf at hawking dot suse dot de> <54D26B54 dot 9050707 at codesourcery dot com> <20150302030859 dot GN19363 at vapier> <550082A3 dot 2010503 at codesourcery dot com>

On 11 Mar 2015 14:00, James Lemke wrote:
> On 03/01/2015 10:08 PM, Mike Frysinger wrote:
> > On 04 Feb 2015 13:56, James Lemke wrote:
> >> --- a/malloc/hooks.c
> >> +++ b/malloc/hooks.c
> >> +{
> >> +  unsigned char magic;
> >> +
> >> +  magic = (((size_t) p >> 3) ^ ((size_t) p >> 11)) & 0xFF;
> >
> > shouldn't you use uintptr_t instead of size_t ?
> 
> It is size_t because that's what the previous macro implementation used.
> I don't see a strong reason to change the casts to uinptr_t,
> but if you do I'll change them.

uintptr_t is the only type you can safely cast a pointer, but if the rest of the 
code is already using size_t, no need to change that in this commit
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] fix to malloc checking
  - From: James Lemke

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]