Re: [PATCH roland/opendir] Refactor opendir.

[Mike Frysinger <vapier at gentoo dot org>]

On 18 May 2015 14:06, Roland McGrath wrote:
> > On 13 May 2015 16:35, Roland McGrath wrote:
> > > I've refactored the opendir implementation, with a few effects.
> > > The main one (and my motivation) is that opendir no longer calls
> > > __opendirat, and so opendir uses only open while only __opendirat
> > > uses openat.
> > 
> > why ?  seems like we generally want to move in the other direction, especially 
> > as newer kernel ports move to not even include non-at syscall variants.
> 
> All the world is Linux and everything we do should be done with Linuxism
> tunnel vision, I know.  But I'm just funny that way.

the *at functions are in POSIX, so having code assume and base itself on that 
assumption makes sense.  especially when it leads to unified & smaller code 
paths.  from your patch, it looks like we're doing the opposite of both.

so i don't see how Linux is related and this patch isn't justified.

also, let's drop the sarcasm as it isn't helping anything.
-mike

Attachment: signature.asc
Description: Digital signature