This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: git commit message conventions
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, Paul Eggert <eggert at cs dot ucla dot edu>, libc-alpha at sourceware dot org
- Date: Wed, 3 Jun 2015 18:11:49 +0200
- Subject: Re: git commit message conventions
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1506022041430 dot 2704 at digraph dot polyomino dot org dot uk> <556E563C dot 1090204 at cs dot ucla dot edu> <alpine dot DEB dot 2 dot 10 dot 1506031010550 dot 4266 at digraph dot polyomino dot org dot uk> <20150603150125 dot GB32684 at spoyarek dot pnq dot redhat dot com>
On Wed, Jun 03, 2015 at 08:31:25PM +0530, Siddhesh Poyarekar wrote:
> On Wed, Jun 03, 2015 at 10:14:19AM +0000, Joseph Myers wrote:
> > I propose that at this point we specifically do not adopt any further
> > conventions regarding how commit messages relate to ChangeLog entries
>
> However, I would love to see us progress to a stage where maintainers
> can simply do a git-am on the patch mbox and push the patch instead of
> manually patching, massaging the ChangeLog, massaging the NEWS file
> and then preparing the commit. The former will take care of most
> cases where a maintainer may forget to set --author when committing
> someone else's patch. I try to make sure I do it for all commits, but
> it's happened more than once that I realized that I hadn't set
> --author after I had pushed the patch.
>
> The part of NEWS that usually conflicts (the bug list) ought to be
> generated from bugzilla. I've said before that I don't find the
> ChangeLog format useful at all, but others have expressed their
> preference to keep it, so that IMO is the only blocker to us following
> the git-am workflow.
>
Correct, I just use script to add bug in NEWS and open bugzilla window so that
isn't as much problem. Changelogs are likewise generated most of time, I
dont have script to extract it from mail, does anybody have one?
As far as I recall discussion only Roland found changelogs useful,
otherwise it was inertia.
> Oh, and using the git-am workflow also allows us to automate patchwork
> so that we don't have to send reminders to clean up their patches
> there.
>
> Siddhesh