This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix lost wake-up when pthread_rwlock_timedrwlock times out.

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: Torvald Riegel <triegel at redhat dot com>
Cc: Joseph Myers <joseph at codesourcery dot com>, GLIBC Devel <libc-alpha at sourceware dot org>
Date: Thu, 4 Jun 2015 13:47:51 +0530
Subject: Re: [PATCH] Fix lost wake-up when pthread_rwlock_timedrwlock times out.
Authentication-results: sourceware.org; auth=none
References: <1429715209 dot 17814 dot 38 dot camel at triegel dot csb> <alpine dot DEB dot 2 dot 10 dot 1504241752410 dot 30193 at digraph dot polyomino dot org dot uk> <1430324093 dot 4450 dot 96 dot camel at triegel dot csb>

On Wed, Apr 29, 2015 at 06:14:53PM +0200, Torvald Riegel wrote:
> diff --git a/nptl/pthread_rwlock_timedwrlock.c b/nptl/pthread_rwlock_timedwrlock.c
> index 416f6e2..958d6db 100644
> --- a/nptl/pthread_rwlock_timedwrlock.c
> +++ b/nptl/pthread_rwlock_timedwrlock.c
> @@ -32,6 +32,7 @@ pthread_rwlock_timedwrlock (rwlock, abstime)
>       const struct timespec *abstime;
>  {
>    int result = 0;
> +  int wake_readers = 0;
>  

Sorry, one small nit I missed and saw when reviewing your other patch:
please make wake_readers bool.

Siddhesh

Attachment: pgpaYUXxxlR8_.pgp
Description: PGP signature

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]