This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Clean up semaphore EINTR handling after Linux futex docs clarification.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Torvald Riegel <triegel at redhat dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Tue, 9 Jun 2015 13:50:39 -0700 (PDT)
- Subject: Re: [PATCH] Clean up semaphore EINTR handling after Linux futex docs clarification.
- Authentication-results: sourceware.org; auth=none
- References: <1433798693 dot 21461 dot 451 dot camel at triegel dot csb>
> + EINTR is returned if we are interrupted by a signal and we
I'd s/and we/; we/ here. As written it feels ambiguous syntactically and
requires real understanding of the context just to see how to parse the
sentence.
> + forward this to the caller. (See futex_wait and related
> + documentation. Before Linux 2.6.22, EINTR was also returned on
> + spurious wake-ups; we only support more recent Linux versions,
Only single space after ; here.
Otherwise seems good to me.
Thanks,
Roland