This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/14] [x86_64] Vector math functions (vector cos)
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>, Martin Sebor <msebor at redhat dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Wed, 10 Jun 2015 10:04:59 +0200
- Subject: Re: [PATCH 1/14] [x86_64] Vector math functions (vector cos)
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1505181711240 dot 20209 at digraph dot polyomino dot org dot uk> <CAMXFM3vG=5KVLuG4HJ6StDp13YcpeRLqPkd=3BJhGt1mu5AWPA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505201529070 dot 23246 at digraph dot polyomino dot org dot uk> <CAMXFM3u57e==ySd8TF7+qFwmrswcT1jqzcN-n_JDPF45+77Z0g at mail dot gmail dot com> <CAMXFM3uuDy3f2hb3Xg+MNmseqjmBFqUF1euRF_g5XW+wo7JSSQ at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505221523570 dot 16611 at digraph dot polyomino dot org dot uk> <CAMXFM3sXNLR3_HPpkUBp_9Ue=-RYZYoidbCwP23Cp9HX_X+t5A at mail dot gmail dot com> <55773335 dot 7000001 at redhat dot com> <CAMXFM3s6Ut_qKEo3t-LDdJXXcFcnpTZZdPT8pjy4n-CedrK5Xw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1506091958370 dot 16480 at digraph dot polyomino dot org dot uk>
On Tue, Jun 09, 2015 at 07:59:57PM +0000, Joseph Myers wrote:
> On Tue, 9 Jun 2015, Andrew Senkevich wrote:
>
> > I have tested build with manually built Binutils 2.24 (downloaded from
> > ftp://sourceware.org/pub/binutils/snapshots/binutils-2.24.90.tar.bz2)
> > on x86_64 Fedora 19 with configure/make with no addition options.
>
> 2.24.90 means a development version in between 2.24 and 2.25. Try actual
> 2.24 release.
>
> If you can't get consensus on requiring a binutils version recent enough
> for this code, you'll need to make the x86_64 configure fragment disable
> libmvec by default if the assembler is too old (and make NEWS and
> install.texi note the requirement when saying it's on by default for
> x86_64).
>
No joseph, thats wrong solution. You don't have to disable entire mvec
just because you don't handle avx512.
Instead add configure test for avx512 and change makefile and surround
selection by ifdefs. We still check for sse4 and dont add memcmp_sse4 if
that configure option failed.