This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 0/8] nptl: Fix Race conditions in pthread cancellation (BZ#12683)
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Sun, 28 Jun 2015 17:14:29 -0300
- Subject: Re: [PATCH 0/8] nptl: Fix Race conditions in pthread cancellation (BZ#12683)
- Authentication-results: sourceware.org; auth=none
- References: <558DABAB dot 40602 at linaro dot org> <alpine dot DEB dot 2 dot 10 dot 1506262108020 dot 28580 at digraph dot polyomino dot org dot uk>
On 26-06-2015 18:08, Joseph Myers wrote:
> Are any of the patches in this set intended as separate commits, or are
> they just posted separately for convenience of review? (Bisectability
> means it's a bad idea to have a commit that breaks builds for an
> architecture and then a separate commit that fixes them.)
>
I see it more logically to divide this implementation for each
port instead of pack everything in a large patch, although I am
not against to push it in only one part.
Also, for arm/aarch64 it shows the minimum required changes to adequate
the port, which make review somewhat easier.
However as I stated the patchset as is only works for the mentioned
architectures and it break on the not supported ones. My idea is
also only push the patchset when all architectures have been ported.