This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] powerpc: New feature - HWCAP/HWCAP2 bits in the TCB

From: Mike Frysinger <vapier at gentoo dot org>
To: Carlos Eduardo Seo <cseo at linux dot vnet dot ibm dot com>
Cc: GLIBC Devel <libc-alpha at sourceware dot org>, Steve Munroe <sjmunroe at us dot ibm dot com>
Date: Wed, 8 Jul 2015 02:00:42 -0400
Subject: Re: [PATCH] powerpc: New feature - HWCAP/HWCAP2 bits in the TCB
Authentication-results: sourceware.org; auth=none
References: <55760314 dot 6070601 at linux dot vnet dot ibm dot com>

On 08 Jun 2015 18:03, Carlos Eduardo Seo wrote:
> +/* Get the hwcap/hwcap2 information from the TCB. Offsets taken
> +   from tcb-offsets.h.  */
> +static inline uint32_t
> +__ppc_get_hwcap (void)
> +{
> +
> +  uint32_t __tcb_hwcap;
> +
> +#ifdef __powerpc64__
> +  register unsigned long __tp __asm__ ("r13");
> +  __asm__ volatile ("lwz %0,-28772(%1)\n"
> +		    : "=r" (__tcb_hwcap)
> +		    : "r" (__tp));
> +#else
> +  register unsigned long __tp __asm__ ("r2");
> +  __asm__ volatile ("lwz %0,-28724(%1)\n"
> +		    : "=r" (__tcb_hwcap)
> +		    : "r" (__tp));
> +#endif
> +
> +  return __tcb_hwcap;
> +}

i'm confused ... why can't the offsets you've already calculated via the 
offsets header be used instead of duplicating them all over this file ?
-mike

Attachment: signature.asc
Description: Digital signature

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]