This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use IE model for static variables in glibc
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 9 Jul 2015 13:40:33 -0700 (PDT)
- Subject: Re: [PATCH] Use IE model for static variables in glibc
- Authentication-results: sourceware.org; auth=none
- References: <20150709180544 dot GA8522 at spoyarek dot pnq dot redhat dot com>
The tests should have comments explaining what they are testing.
If it's important that all TLS accesses in libc code be IE, then there
should be a static test for that. Perhaps it could grep readelf -r output
for the TLS dynamic reloc types. Or perhaps there is something we could do
to make references to __tls_get_addr when linking libc.so be a hard failure.
If the intent is to catch all TLS access in libc code, then why are you
touching the source instead of just compiling with -ftls-model=initial-exec
across the board? If we do that, then it's probably fine not to have the
static test.
Thanks,
Roland