This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix BZ #18086 (nice resets errno to 0)

From: Mike Frysinger <vapier at gentoo dot org>
To: Paul Pluzhnikov <ppluzhnikov at gmail dot com>
Cc: GLIBC Devel <libc-alpha at sourceware dot org>, Paul Pluzhnikov <ppluzhnikov at google dot com>
Date: Sun, 9 Aug 2015 22:19:44 -0400
Subject: Re: Fix BZ #18086 (nice resets errno to 0)
Authentication-results: sourceware.org; auth=none
References: <CAPC3xaoD55Kc9x=JuPnCKqQncSeAXv2+X=Qrd7u7nXFG2usRTQ at mail dot gmail dot com>

On 09 Aug 2015 16:28, Paul Pluzhnikov wrote:
> +      printf ("FAIL: errno = %d != EBADF\n", errno);

i often find error messages like this hard to parse.  explicit is better:
	printf ("FAIL: errno = %i, but wanted EBADF (%i)\n", errno, EBADF);

> @@ -47,5 +45,7 @@ nice (int incr)
>  	errno = EPERM;

not really related, but shouldn't this use __set_errno ?
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: Fix BZ #18086 (nice resets errno to 0)
  - From: Paul Pluzhnikov

References:
- Fix BZ #18086 (nice resets errno to 0)
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]