This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix a buglet in malloc/mtrace.pl

On Fri, Aug 14, 2015 at 12:31 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Paul Pluzhnikov <ppluzhnikov@gmail.com> writes:
>

>> -         } else {
>> +         } elsif ($allocaddr != "(nil}") {
>
> Can this ever be false?

Oops. You are almost right: the condition above is actually never
false (my Perl is getting rusty, one does not simply compare strings
with != in Perl!).
The end result is that all leak detection is suppressed :-(

Corrected patch attached.



-- 
Paul Pluzhnikov

Attachment: mtrace-20150814.txt
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]