This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix memory leak in printf_positional

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: "Carlos O'Donell" <carlos at redhat dot com>
Cc: Joseph Myers <joseph at codesourcery dot com>, Paul Eggert <eggert at cs dot ucla dot edu>, GLIBC Devel <libc-alpha at sourceware dot org>
Date: Wed, 2 Sep 2015 22:48:04 -0700
Subject: Re: [PATCH] Fix memory leak in printf_positional
Authentication-results: sourceware.org; auth=none
References: <1440571295-20230-1-git-send-email-eggert at cs dot ucla dot edu> <alpine dot DEB dot 2 dot 10 dot 1508260930500 dot 26898 at digraph dot polyomino dot org dot uk> <55DFB7C7 dot 50307 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1508281350520 dot 5939 at digraph dot polyomino dot org dot uk> <55E06924 dot 2000209 at redhat dot com> <CALoOobMkGafD9zvq9g13TM8_Nd+HmC58_8gMGTQhdefXpko3CA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1508311039110 dot 27932 at digraph dot polyomino dot org dot uk> <CALoOobO2iV9hPNB_S7PDoL=cWVCPrSkKGaUQfqboxUg40fsrVw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1509021004030 dot 3590 at digraph dot polyomino dot org dot uk> <CALoOobN6LcGFEkieN3CJQ7mKeL7m5H3_aaYb17uEW9ZE_zX4yA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1509021427530 dot 27392 at digraph dot polyomino dot org dot uk> <55E73436 dot 1050305 at redhat dot com>

On Wed, Sep 2, 2015 at 10:39 AM, Carlos O'Donell <carlos@redhat.com> wrote:

>>> I think at that point it becomes easier to just use a generator script
>>> to write the test. Any objection to that?
>>
>> I don't object to that given an appropriate comment on why it is being
>> used.
>
> Agreed.

What's the appropriate place to put this comment?

2015-09-01  Paul Eggert  <eggert@cs.ucla.edu>
         Paul Pluzhnikov  <ppluzhnikov@google.com>

        [BZ #18872]
        * stdio-common/Makefile (tst-printf-bz18872): New test.
        (tst-printf-bz18872-mem.out): Likewise.
        * stdio-common/tst-printf-bz18872.sh: Generate new test.
        * stdio-common/vfprintf.c: Fix memory leaks.



-- 
Paul Pluzhnikov

Attachment: bz18872.20150902a.txt
Description: Text document

Follow-Ups:
- Re: [PATCH] Fix memory leak in printf_positional
  - From: Andreas Schwab
- Re: [PATCH] Fix memory leak in printf_positional
  - From: Joseph Myers
- Re: [PATCH] Fix memory leak in printf_positional
  - From: Carlos O'Donell

References:
- Re: [PATCH] Fix memory leak in printf_positional
  - From: Paul Pluzhnikov
- Re: [PATCH] Fix memory leak in printf_positional
  - From: Joseph Myers
- Re: [PATCH] Fix memory leak in printf_positional
  - From: Paul Pluzhnikov
- Re: [PATCH] Fix memory leak in printf_positional
  - From: Joseph Myers
- Re: [PATCH] Fix memory leak in printf_positional
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]