This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use builtins in signbit implementation


On Fri, 4 Sep 2015, Wilco Dijkstra wrote:

> Use the GCC builtin functions for the non-inlined signbit implementations.
> This excludes the 128ibm format as I'm not sure whether the builtins work 
> for that case.

signbit should work fine for ldbl-128ibm (it's copysign and fabs that have 
issues in some cases).

> @@ -19,13 +19,9 @@
>  
>  #include <math.h>
>  
> -#include <math_private.h>
>  

I'd say that when removing this #include, one of the blank lines about it 
should be removed as well.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]