This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[COMMITTED] Fix check-local-headers when no input is found.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 14 Sep 2015 09:57:47 -0400
- Subject: [COMMITTED] Fix check-local-headers when no input is found.
- Authentication-results: sourceware.org; auth=none
Consensus in [1] was that the right way to fix this was simply to
redirect from /dev/null to terminate the test if no inputs was found
by the tests own globbing e.g. "*/*.{o,os,oS}.d" This can happen when
the build is incomplete and the tests are started. This failure causes
check-local-headers.sh to hang forever waiting for input from stdin.
This change makes the test terminate immediately if the glob doesn't
return any files.
[1] https://sourceware.org/ml/libc-alpha/2014-12/msg00337.html
2015-09-14 Carlos O'Donell <carlos@redhat.com>
* Makefile ($(objpfx)check-local-headers.out): Redirect stdin from
/dev/null.
diff --git a/Makefile b/Makefile
index e07309e..a2abfb9 100644
--- a/Makefile
+++ b/Makefile
@@ -262,7 +262,7 @@ endif
$(objpfx)check-local-headers.out: scripts/check-local-headers.sh
AWK='$(AWK)' scripts/check-local-headers.sh \
- "$(includedir)" "$(objpfx)" > $@; \
+ "$(includedir)" "$(objpfx)" < /dev/null > $@; \
$(evaluate-test)
ifneq ($(PERL),no)
---
Cheers,
Carlos.