This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix BZ 18985 out of bounds access in strftime

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: Paul Eggert <eggert at cs dot ucla dot edu>
Cc: GLIBC Devel <libc-alpha at sourceware dot org>
Date: Sun, 20 Sep 2015 13:15:52 -0700
Subject: Re: [patch] Fix BZ 18985 out of bounds access in strftime
Authentication-results: sourceware.org; auth=none
References: <CAPC3xao-5YF_icBWE5yYbaYiUmiAvmb7w9s_G-dqawsx7eoTkQ at mail dot gmail dot com> <55FE5473 dot 7030305 at cs dot ucla dot edu> <CALoOobOWfPWuwtw_XgcTKx2yn=p3YbB04_B965zKRCkC1qsPjQ at mail dot gmail dot com> <55FEFD47 dot 4090401 at cs dot ucla dot edu> <CALoOobMOFtQVcCK4bR3VpeLMoj4bXVa12GAk0CjP6MMxuQU+Fw at mail dot gmail dot com>

On Sun, Sep 20, 2015 at 11:45 AM, Paul Pluzhnikov
<ppluzhnikov@google.com> wrote:
> On Sun, Sep 20, 2015 at 11:39 AM, Paul Eggert <eggert@cs.ucla.edu> wrote:

>> Don't forget out-of-range tm_isdst: there's one place the code has undefined
>> behavior if tm_isdst exceeds 1.

Let's try again, now with a test case :-)


2015-09-20  Paul Pluzhnikov  <ppluzhnikov@google.com>

        [BZ #18985]
        * time/strftime_l.c (a_wkday, f_wkday, a_month, f_month): Range check.
        (__strftime_internal): Likewise.
        * time/tst-strftime.c (do_bz18985): New test.
        (do_test): Call it.

-- 
Paul Pluzhnikov

Attachment: glibc-bz18985-20150920.txt
Description: Text document

Follow-Ups:
- Re: [patch] Fix BZ 18985 out of bounds access in strftime
  - From: Andreas Schwab

References:
- [patch] Fix BZ 18985 out of bounds access in strftime
  - From: Paul Pluzhnikov
- Re: [patch] Fix BZ 18985 out of bounds access in strftime
  - From: Paul Eggert
- Re: [patch] Fix BZ 18985 out of bounds access in strftime
  - From: Paul Pluzhnikov
- Re: [patch] Fix BZ 18985 out of bounds access in strftime
  - From: Paul Eggert
- Re: [patch] Fix BZ 18985 out of bounds access in strftime
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]