This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[patch] Fix BZ 19012 -- memory leak on error path in iconv_open

From: Paul Pluzhnikov <ppluzhnikov at gmail dot com>
To: GLIBC Devel <libc-alpha at sourceware dot org>
Cc: Paul Pluzhnikov <ppluzhnikov at google dot com>
Date: Sun, 27 Sep 2015 14:22:13 -0700
Subject: [patch] Fix BZ 19012 -- memory leak on error path in iconv_open
Authentication-results: sourceware.org; auth=none

Greetings,

Attached patch fixes the leak, but doesn't add a test case.

In order to expose the bug, a partial install (one missing
iconvdata/SJIS.so) is required. I am not sure how to write such a test
case (or even whether it is truly a bug to leak memory when faced with
such a partial install).

Thanks,

2015-09-27  Paul Pluzhnikov  <ppluzhnikov@google.com>

        [BZ #19012]
        * iconv/gconv_db.c (gen_steps): Clean up on error.

-- 
Paul Pluzhnikov

Attachment: glibc-bz19012-20150927.txt
Description: Text document

Follow-Ups:
- Re: [patch] Fix BZ 19012 -- memory leak on error path in iconv_open
  - From: Carlos O'Donell
- Re: [patch] Fix BZ 19012 -- memory leak on error path in iconv_open
  - From: Florian Weimer
- Re: [patch] Fix BZ 19012 -- memory leak on error path in iconv_open
  - From: Mike Frysinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]