Re: [PATCH] 18969 - multiple string test failures due to missing locale dependencies

[Mike Frysinger <vapier at gentoo dot org>]

On 24 Sep 2015 15:58, Martin Sebor wrote:
> After glibc has been built but before 'make check' has been invoked,
> running 'make check subdirs=string' causes four string tests to fail
> that otherwise succeed.  The failures can also be reproduced by
> removing the contents of the localedata directory and invoking make
> check as shown below.  The cause of the failures is a missing
> dependency of the string makefile on the locales used by string tests.
> 
> In addition, while three of the four tests produce output that makes
> the reason for their failures clear by printing the names of the
> locales they couldn't set, string/tst-strxfrm2 prints the less helpful
> "setlocale failed."
> 
> The patch attached to the bug and copied below fixes both problems
> by a) adding the missing dependency on gen-locales.mk to
> string/Makefile and setting the LOCALES variable to the names of
> the prerequisite locales, and b) printing the name of the failed
> locale in tst-strxfrm2.
> 
> The patch was tested on powerpc64le.

hmm, i see this was pushed now, but with this commit message:

commit 60cf80f09d029257caedc0c8abe7e3e09c64e6c7
Author: Martin Sebor <msebor@gcc.gnu.org>
Date:   Mon Sep 28 16:55:57 2015 -0400

    Let 'make check subdirs=string' succeed even when it's invoked
    immediately after glibc has been built and before 'make check'
    (or after 'make clean').

the glibc git repo should generally follow more git-like flows.  so
in this case, the commit message should have been something like:
======
fix handling of locale data with string tests [BZ #18969]

After glibc has been built but before 'make check' has been invoked,
running 'make check subdirs=string' causes four string tests to fail
that otherwise succeed.  The failures can also be reproduced by
removing the contents of the localedata directory and invoking make
...<the rest of the e-mail you sent>...
===
-mike

Attachment: signature.asc
Description: Digital signature