This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 00/13] nptl: Fix Race conditions in pthread cancellation (BZ#12683)
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Date: Wed, 7 Oct 2015 19:05:32 -0300
- Subject: Re: [PATCH 00/13] nptl: Fix Race conditions in pthread cancellation (BZ#12683)
- Authentication-results: sourceware.org; auth=none
- References: <1444234995-9542-1-git-send-email-adhemerval dot zanella at linaro dot com> <alpine dot DEB dot 2 dot 10 dot 1510071645260 dot 29388 at digraph dot polyomino dot org dot uk> <5615635F dot 5030306 at linaro dot org> <20151007210127 dot A30C02C39DF at topped-with-meat dot com> <5615934F dot 1050804 at linaro dot org>
On 07-10-2015 18:49, Adhemerval Zanella wrote:
>
>
> On 07-10-2015 18:01, Roland McGrath wrote:
>>> My mistake, I have it changed in the initial cover letter, but I forgot
>>> to re-add when I had to rewrite it. And my understanding is for ILP32
>>> sizeof(long int) is the same as the sizeof(void*).
>>
>> No reason to assume that. Use uintptr_t.
>>
>
> Right, but I am not aware of any GLIBC supported system where sizeof(long)
> differs from sizeof(uintptr_t).
>
But I see no problem on changing the function return to uintptr_t. I will
change that.