This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv2] powerpc: Fix usage of elision transient failure adapt param
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
- Cc: "libc-alpha\ at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc:
- Date: Tue, 27 Oct 2015 17:35:44 -0200
- Subject: Re: [PATCHv2] powerpc: Fix usage of elision transient failure adapt param
- Authentication-results: sourceware.org; auth=none
- References: <55DF2324 dot 2040308 at linux dot vnet dot ibm dot com>
"Paul E. Murphy" <murphyp@linux.vnet.ibm.com> writes:
> This is now rebased around Tulio's fix for elide.h:
> http://patchwork.sourceware.org/patch/8413/
>
> Changes are fairly trivial. Note, attempt goes from
> try_tbegin towards 0, but not to 0.
>
> ---
> The skip_lock_out_of_tbegin_retries adaptive parameter was
> not being used correctly, nor as described. This prevents
> a fallback for all users of the lock if a transient abort
> occurs within the accepted number of retries.
>
> 2015-08-26 Paul E. Murphy <murphyp@linux.vnet.ibm.com>
> * sysdeps/powerpc/nptl/elide.h(__elide_lock): Fix
> usage of .skip_lock_out_of_tbegin_retries
> * sysdeps/unix/sysv/linux/powerpc/elision-lock.c
> * (__lll_lock_elision):
> Likewise, and respect a value of try_tbegin <= 0
I added a reference to bug #19174 and pushed it as 72f1463.
Thanks!
--
Tulio Magno