This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING 2][PATCH v3] Add pretty printers for the NPTL lock types
- From: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org, Tom Tromey <tom at tromey dot com>, "Carlos O'Donell" <carlos at redhat dot com>, Torvald Riegel <triegel at redhat dot com>, Pedro Alves <palves at redhat dot com>, vapier at gentoo dot org, Daniel Gutson <daniel dot gutson at tallertechnologies dot com>
- Date: Tue, 17 Nov 2015 14:26:05 -0300
- Subject: Re: [PING 2][PATCH v3] Add pretty printers for the NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <1447768994-5368-1-git-send-email-martin dot galvan at tallertechnologies dot com> <564B4DE4 dot 7010306 at redhat dot com>
On Tue, Nov 17, 2015 at 12:55 PM, Florian Weimer <fweimer@redhat.com> wrote:
> Is there a test for this somewhere? Can it be put into glibc?
If you mean automated unit tests, then no, there aren't any. I think
including them in glibc would be quite a hassle, since they'd need to
interact with gdb as well.
When developing these printers I based my work on the ones for
libstdc++. I think those don't come with unit tests either.
> I'm worried that these helpers break the debugging experience at some
> point, and we would like to catch that early.
Notice these printers won't necessarily have to be enabled by default.
If there was a problem with the printers, the user can simply keep the
default printing behavior. libstdc++ does this as well: I had to add a
bit of code to my .gdbinit so that those printers will always load
them at startup.
This is merely a tool to make the user's life easier. It's not by any
means a requirement for using glibc.