This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] x86_64: memset optimized with AVX512
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, Richard Henderson <rth at twiddle dot net>
- Date: Thu, 10 Dec 2015 11:34:45 -0800
- Subject: Re: [PATCH] x86_64: memset optimized with AVX512
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3v7K1bO8aUB=rVBzKqAZJuNrMBh5NuyszONtB-sZrXcgA at mail dot gmail dot com> <CAMe9rOrmhNzZTjX9XS2ONhTghCU-UXs3WmWzRWkXhWHCDZi8GQ at mail dot gmail dot com> <CAMXFM3uDEgQyfmJtVzp8QqYCEFJpYMTENhG3RMu26_R6eeAs3g at mail dot gmail dot com>
On Thu, Dec 10, 2015 at 10:28 AM, Andrew Senkevich
<andrew.n.senkevich@gmail.com> wrote:
>>> END (MEMSET)
>>> +libc_hidden_def (__memset_avx2)
>>
>> Why is this change needed? If it is needed, please submit
>> a separate patch.
>
> We can avoid this change if hide implementation, test and IFUNC branch
> under HAVE_AVX512_ASM_SUPPORT.
>
>> Should __memset_chk_avx512 also be provided?
>
> It will be the same as AVX2 version, is it really needed?
__memset_chk_avx2 calls __memset_avx2. Don't you want
__memset_chk to call __memset_avx512, instead of __memset_avx2,
on KNL?
--
H.J.