This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] [BZ #19363] Use INTERNAL_SYSCALL_TIMES for Linux times

From: Mike Frysinger <vapier at gentoo dot org>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Mon, 14 Dec 2015 22:59:17 -0500
Subject: Re: [PATCH] [BZ #19363] Use INTERNAL_SYSCALL_TIMES for Linux times
Authentication-results: sourceware.org; auth=none
References: <20151215032733 dot GA14426 at gmail dot com>

On 14 Dec 2015 19:27, H.J. Lu wrote:
> +  clock_t ret = INTERNAL_SYSCALL_TIMES(err, buf);

needs a space before the (

> +/* Incline Linux times system calls.  */

"incline" ?  i don't understand what you mean.

> +# define INTERNAL_SYSCALL_TIMES(err, buf)				\

no space after the #

> +  ({									\
> +    unsigned long long int resultvar;					\
> +    LOAD_ARGS_1 (buf)							\
> +    LOAD_REGS_1								\
> +    asm volatile (							\
> +    "syscall\n\t"							\
> +    : "=a" (resultvar)							\
> +    : "0" (__NR_times) ASM_ARGS_1 : "memory", "cc", "r11", "cx");	\

should the cc/r11/cx be made into a sysdep define ?
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] [BZ #19363] Use INTERNAL_SYSCALL_TIMES for Linux times
  - From: H.J. Lu

References:
- [PATCH] [BZ #19363] Use INTERNAL_SYSCALL_TIMES for Linux times
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]