This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] malloc: Test various special cases related to allocation failures

On Mon, Dec 28, 2015 at 08:42:50PM +0100, Florian Weimer wrote:
> This test case exercises unusual code paths in allocation functions,
> related to allocation failures.

LGTM.

[...]
> +  if (page_size != 4096)
> +    {
> +      allocation_size = page_size;
> +      run_allocation_functions ();
> +    }

Why this test is not needed for page_size == 4096?
It might worth a comment.


-- 
ldv

Attachment: pgpGP1HQz7Zwt.pgp
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]