This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3] Add pretty printers for the NPTL lock types

From: Mike Frysinger <vapier at gentoo dot org>
To: Martin Galvan <martin dot galvan at tallertechnologies dot com>
Cc: libc-alpha at sourceware dot org, tom at tromey dot com, carlos at redhat dot com, triegel at redhat dot com, palves at redhat dot com, daniel dot gutson at tallertechnologies dot com
Date: Fri, 8 Jan 2016 03:23:25 -0500
Subject: Re: [PATCH v3] Add pretty printers for the NPTL lock types
Authentication-results: sourceware.org; auth=none
References: <CAOKbPbbVud=gru917mXYfnOnQ9nCCY1vR4fvyU8JpRVzaGe5bw at mail dot gmail dot com> <1446939548-30602-1-git-send-email-martin dot galvan at tallertechnologies dot com>

On 07 Nov 2015 20:39, Martin Galvan wrote:
> --- /dev/null
> +++ b/nptl/nptl-printers.py
> +import sys

as the linter points out, this is unused, so you should drop it

can you post a v4 with all the comments fixed ?

> +MUTEX_TYPES = {
> +    PTHREAD_MUTEX_NORMAL: ('Type', 'Normal'),
> +    PTHREAD_MUTEX_RECURSIVE: ('Type', 'Recursive'),
> +    PTHREAD_MUTEX_ERRORCHECK: ('Type', 'Error check'),
> +    PTHREAD_MUTEX_ADAPTIVE_NP: ('Type', 'Adaptive')
> +}

imo, we should have dangling commas with lists/dicts/tuples like we do
in C with arrays.
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH v3] Add pretty printers for the NPTL lock types
  - From: Martin Galvan

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]