This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/4] Consolidate pread/pread64 implementations

From: Mike Frysinger <vapier at gentoo dot org>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: libc-alpha at sourceware dot org, Adhemerval Zanella <adhemerval dot zanella at linaro dot com>
Date: Fri, 8 Jan 2016 15:48:04 -0500
Subject: Re: [PATCH 3/4] Consolidate pread/pread64 implementations
Authentication-results: sourceware.org; auth=none
References: <1452187108-6504-1-git-send-email-adhemerval dot zanella at linaro dot org> <1452187108-6504-4-git-send-email-adhemerval dot zanella at linaro dot org> <20160107195245 dot GB25548 at vapier dot lan> <568ECAEE dot 9020602 at linaro dot org> <20160107205418 dot GE25548 at vapier dot lan> <568ED2AD dot 3000109 at linaro dot org> <568FB8D8 dot 8090802 at linaro dot org>

On 08 Jan 2016 11:25, Adhemerval Zanella wrote:
> +#if !(__WORDSIZE == 64) && !defined(__ASSUME_WORDSIZE64_ILP32)

!(... == ...) should be written as ... != ...

otherwise this seems to get the job done
-mike

Attachment: signature.asc
Description: Digital signature

References:
- [PATCH 0/4] Cancellation entrypoint refactor
  - From: Adhemerval Zanella
- [PATCH 3/4] Consolidate pread/pread64 implementations
  - From: Adhemerval Zanella
- Re: [PATCH 3/4] Consolidate pread/pread64 implementations
  - From: Mike Frysinger
- Re: [PATCH 3/4] Consolidate pread/pread64 implementations
  - From: Adhemerval Zanella
- Re: [PATCH 3/4] Consolidate pread/pread64 implementations
  - From: Mike Frysinger
- Re: [PATCH 3/4] Consolidate pread/pread64 implementations
  - From: Adhemerval Zanella
- Re: [PATCH 3/4] Consolidate pread/pread64 implementations
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]