This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[patch] Use ENTRY/END in sysdeps/x86_64/nptl/pthread_spin*.S

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: GLIBC Devel <libc-alpha at sourceware dot org>
Cc: Wei Mi <wmi at google dot com>
Date: Mon, 18 Jan 2016 13:11:16 -0800
Subject: [patch] Use ENTRY/END in sysdeps/x86_64/nptl/pthread_spin*.S
Authentication-results: sourceware.org; auth=none

Greetings,

Currently, x86_64 pthread_spin_{lock,unlock,trylock} lack unwind
descriptors, which causes tools like GDB and libunwind to guess how to
unwind from them. Libunwind happens to guess incorrectly, leading to
either bad stack trace, or a crash.

Attached patch fixes this. Tested on Linux/x86_64. Ok for trunk?

P.S. I'd like to excise other instances of functions that lack unwind
descriptors in a follow-up patch, if that's ok.

2016-01-18  Paul Pluzhnikov  <ppluzhnikov@google.com>

        * sysdeps/x86_64/nptl/pthread_spin_lock.S (pthread_spin_lock):
Use ENTRY/END
        * sysdeps/x86_64/nptl/pthread_spin_trylock.S
(pthread_spin_trylock): Likewise
        * sysdeps/x86_64/nptl/pthread_spin_unlock.S
(pthread_spin_unlock): Likewise

-- 
Paul Pluzhnikov

Attachment: glibc-20160118-CFI.txt
Description: Text document

Follow-Ups:
- Re: [patch] Use ENTRY/END in sysdeps/x86_64/nptl/pthread_spin*.S
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]